Bug 201648

Summary: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cookies/private-cookie-storage.html
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, beidson, commit-queue, ews-watchlist, ggaren, gyuyoung.kim, rakuco, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201546    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews213 for win-future
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-09-10 10:23:00 PDT
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cookies/private-cookie-storage.html.
Attachments
Patch (6.78 KB, patch)
2019-09-10 10:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (13.78 MB, application/zip)
2019-09-10 12:11 PDT, EWS Watchlist 		no flags
Details
Patch (18.23 KB, patch)
2019-09-10 12:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.25 KB, patch)
2019-09-10 13:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.21 KB, patch)
2019-09-10 14:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.09 KB, patch)
2019-09-10 15:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-10 10:27:08 PDT
Created attachment 378468 [details] Patch
EWS Watchlist
Comment 2 2019-09-10 12:10:53 PDT
Comment on attachment 378468 [details] Patch Attachment 378468 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13020346 New failing tests: http/tests/cookies/private-cookie-storage.html
EWS Watchlist
Comment 3 2019-09-10 12:11:02 PDT
Created attachment 378473 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Chris Dumez
Comment 4 2019-09-10 12:37:53 PDT
Created attachment 378474 [details] Patch
Chris Dumez
Comment 5 2019-09-10 13:17:04 PDT
Created attachment 378478 [details] Patch
Chris Dumez
Comment 6 2019-09-10 14:17:05 PDT
Created attachment 378491 [details] Patch
Chris Dumez
Comment 7 2019-09-10 15:02:00 PDT
Created attachment 378497 [details] Patch
Chris Dumez
Comment 8 2019-09-10 16:43:21 PDT
Alex, could you please take another look? I had to add test infrastructure for Windows to get the test working there.
Alex Christensen
Comment 9 2019-09-10 16:50:38 PDT
Comment on attachment 378497 [details] Patch Sure
WebKit Commit Bot
Comment 10 2019-09-10 17:35:25 PDT
Comment on attachment 378497 [details] Patch Clearing flags on attachment: 378497 Committed r249746: <https://trac.webkit.org/changeset/249746>
WebKit Commit Bot
Comment 11 2019-09-10 17:35:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-09-10 17:36:31 PDT
<rdar://problem/55244424>
Radar WebKit Bug Importer
Comment 13 2019-09-10 17:36:32 PDT
<rdar://problem/55244425>
Note You need to log in before you can comment on or make changes to this bug.