Bug 201638

Summary: UserMediaProcessManager is revoking sandbox extensions too aggressively
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 200975    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2019-09-10 04:03:38 PDT
UserMediaProcessManager is revoking sandbox extensions too aggressively
Comment 1 youenn fablet 2019-09-10 04:11:00 PDT
Created attachment 378455 [details]
Patch
Comment 2 Eric Carlson 2019-09-10 05:59:22 PDT
Comment on attachment 378455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378455&action=review

> Source/WebKit/ChangeLog:11
> +        Sandbox revocation was sometimes happening when a page is being closed while another page from the same process is starting capture.
> +        In that case, revocation might happen while it should not.
> +        To prevent this, we do not revoke sandbox extensions if there are pending captures for a page of the process.
> +        Whenever a page does not have any pending capture, sandbox extensions may be revoked.

Nit: it is probably worth mentioning that these changes fixes an existing test.
Comment 3 youenn fablet 2019-09-10 06:07:49 PDT
Created attachment 378458 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-09-10 06:52:43 PDT
Comment on attachment 378458 [details]
Patch for landing

Clearing flags on attachment: 378458

Committed r249712: <https://trac.webkit.org/changeset/249712>
Comment 5 WebKit Commit Bot 2019-09-10 06:52:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-10 06:53:13 PDT
<rdar://problem/55220850>