Bug 201590

Summary: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201546    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2019-09-08 10:04:22 PDT
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html.
Attachments
Patch (9.87 KB, patch)
2019-09-08 10:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.85 KB, patch)
2019-09-09 09:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-08 10:25:20 PDT
Created attachment 378328 [details] Patch
youenn fablet
Comment 2 2019-09-08 23:10:17 PDT
Comment on attachment 378328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378328&action=review > Tools/ChangeLog:8 > + Add a new API test to check that if the default session registers a service workers, the s/workers/worker/ > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1508 > + configuration.get().websiteDataStore = [WKWebsiteDataStore nonPersistentDataStore]; We were using an ephemeral session in the layout test because that was all we had. This test could be written with a non ephemeral session.
Chris Dumez
Comment 3 2019-09-09 09:39:51 PDT
Created attachment 378375 [details] Patch
WebKit Commit Bot
Comment 4 2019-09-09 10:18:31 PDT
Comment on attachment 378375 [details] Patch Clearing flags on attachment: 378375 Committed r249648: <https://trac.webkit.org/changeset/249648>
WebKit Commit Bot
Comment 5 2019-09-09 10:18:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-09 10:19:20 PDT
<rdar://problem/55186932>
Radar WebKit Bug Importer
Comment 7 2019-09-09 10:19:24 PDT
<rdar://problem/55186936>
Note You need to log in before you can comment on or make changes to this bug.