Summary: | Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Tools / Tests | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 201546 | ||||||||
Attachments: |
|
Description
Chris Dumez
2019-09-08 10:04:22 PDT
Created attachment 378328 [details]
Patch
Comment on attachment 378328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378328&action=review > Tools/ChangeLog:8 > + Add a new API test to check that if the default session registers a service workers, the s/workers/worker/ > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1508 > + configuration.get().websiteDataStore = [WKWebsiteDataStore nonPersistentDataStore]; We were using an ephemeral session in the layout test because that was all we had. This test could be written with a non ephemeral session. Created attachment 378375 [details]
Patch
Comment on attachment 378375 [details] Patch Clearing flags on attachment: 378375 Committed r249648: <https://trac.webkit.org/changeset/249648> All reviewed patches have been landed. Closing bug. |