Bug 201574 – Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which does not work well for WK2.

[Chris Dumez]

Created attachment 378271 [details]
Patch

[Alex Christensen]

Comment on attachment 378271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378271&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419
> +    auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);

In order for this to be an equivalent test, don't you need to set the processPool to be the same as the defaultWebView?

[Chris Dumez]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 378271 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378271&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419
> > +    auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
> 
> In order for this to be an equivalent test, don't you need to set the
> processPool to be the same as the defaultWebView?

Well, that is a good point. For some reason, I assumed this was the default behavior :/ will fix.

[Chris Dumez]

Created attachment 378297 [details]
Patch

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> (In reply to Alex Christensen from comment #2)
> > Comment on attachment 378271 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=378271&action=review
> > 
> > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419
> > > +    auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
> > 
> > In order for this to be an equivalent test, don't you need to set the
> > processPool to be the same as the defaultWebView?
> 
> Well, that is a good point. For some reason, I assumed this was the default
> behavior :/ will fix.

Done.

[WebKit Commit Bot]

Comment on attachment 378297 [details]
Patch

Clearing flags on attachment: 378297

Committed r249626: <https://trac.webkit.org/changeset/249626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55155561>

[Radar WebKit Bug Importer]

<rdar://problem/55155563>