Summary: | Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 201546 | ||||||||
Attachments: |
|
Description
Chris Dumez
2019-09-06 20:46:34 PDT
Created attachment 378271 [details]
Patch
Comment on attachment 378271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378271&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419 > + auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]); In order for this to be an equivalent test, don't you need to set the processPool to be the same as the defaultWebView? (In reply to Alex Christensen from comment #2) > Comment on attachment 378271 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378271&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419 > > + auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]); > > In order for this to be an equivalent test, don't you need to set the > processPool to be the same as the defaultWebView? Well, that is a good point. For some reason, I assumed this was the default behavior :/ will fix. Created attachment 378297 [details]
Patch
(In reply to Chris Dumez from comment #3) > (In reply to Alex Christensen from comment #2) > > Comment on attachment 378271 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=378271&action=review > > > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1419 > > > + auto ephemeralConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]); > > > > In order for this to be an equivalent test, don't you need to set the > > processPool to be the same as the defaultWebView? > > Well, that is a good point. For some reason, I assumed this was the default > behavior :/ will fix. Done. Comment on attachment 378297 [details] Patch Clearing flags on attachment: 378297 Committed r249626: <https://trac.webkit.org/changeset/249626> All reviewed patches have been landed. Closing bug. |