Bug 201522

Summary:

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, beidson, commit-queue, ews-watchlist, ggaren, jsbell, koivisto, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

201475

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews215 for win-future	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-09-05 15:25:58 PDT

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js since it does not do the right thing for WebKit2.

Attachments
Patch (181.48 KB, patch) 2019-09-05 15:30 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews215 for win-future (13.66 MB, application/zip) 2019-09-05 17:48 PDT, EWS Watchlist	no flags	Details
Patch (182.24 KB, patch) 2019-09-05 18:44 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (182.24 KB, patch) 2019-09-05 19:35 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-09-05 15:30:26 PDT

Created attachment 378130 [details] Patch

EWS Watchlist

Comment 2 2019-09-05 17:48:45 PDT

Comment on attachment 378130 [details] Patch Attachment 378130 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13002481 New failing tests: storage/indexeddb/transaction-error-private.html storage/indexeddb/odd-strings-private.html storage/indexeddb/version-change-abort-private.html storage/indexeddb/modern/transaction-scheduler-6-private.html storage/indexeddb/modern/transaction-scheduler-2-private.html storage/indexeddb/modern/transaction-scheduler-5-private.html storage/indexeddb/modern/transaction-scheduler-1-private.html storage/indexeddb/exception-in-event-aborts-private.html storage/indexeddb/transaction-coordination-within-database-private.html

EWS Watchlist

Comment 3 2019-09-05 17:48:48 PDT

Created attachment 378141 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Chris Dumez

Comment 4 2019-09-05 18:28:32 PDT

Comment on attachment 378130 [details] Patch Well, that is interesting, I will investigate the failures.

Chris Dumez

Comment 5 2019-09-05 18:44:26 PDT

Created attachment 378147 [details] Patch

Chris Dumez

Comment 6 2019-09-05 19:35:38 PDT

Created attachment 378152 [details] Patch

WebKit Commit Bot

Comment 7 2019-09-05 22:06:44 PDT

Comment on attachment 378152 [details] Patch Clearing flags on attachment: 378152 Committed r249563: <https://trac.webkit.org/changeset/249563>