Bug 201519

Summary: Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, koivisto, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201475    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-09-05 15:07:22 PDT
Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing.
Attachments
Patch (4.77 KB, patch)
2019-09-05 15:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-05 15:09:36 PDT
Created attachment 378127 [details] Patch
Alex Christensen
Comment 2 2019-09-05 20:15:46 PDT
Comment on attachment 378127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378127&action=review > Tools/WebKitTestRunner/TestOptions.cpp:61 > + return pathContains(pathOrURL, "w3c/IndexedDB-private-browsing") || pathContains(pathOrURL, "w3c\\IndexedDB-private-browsing"); Maybe pathContains should be made to replace '\\' with '/' before doing the comparison so we don't need both of these for all call sites.
WebKit Commit Bot
Comment 3 2019-09-05 22:57:29 PDT
Comment on attachment 378127 [details] Patch Clearing flags on attachment: 378127 Committed r249564: <https://trac.webkit.org/changeset/249564>
WebKit Commit Bot
Comment 4 2019-09-05 22:57:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-09-05 22:58:18 PDT
<rdar://problem/55101171>
Note You need to log in before you can comment on or make changes to this bug.