Summary: | Make NetworkConnectionToWebProcess keyed by its WebProcess identifier | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 201299 | ||||||||||||
Attachments: |
|
Description
youenn fablet
2019-08-29 06:03:33 PDT
Created attachment 377572 [details]
Patch
Created attachment 377691 [details]
Patch
Created attachment 377695 [details]
Patch
Comment on attachment 377695 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377695&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:389 > + return std::make_pair(socketPair.server, IPC::Attachment { socketPair.client }); You could use {} instead of std::make_pair > Source/WebKit/NetworkProcess/NetworkProcess.cpp:420 > + completionHandler({ }); WTF::null opt (In reply to Alex Christensen from comment #4) > Comment on attachment 377695 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377695&action=review > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:389 > > + return std::make_pair(socketPair.server, IPC::Attachment { socketPair.client }); > > You could use {} instead of std::make_pair The function returns an Optional<std::pair> so we need to return a pair explicitly here. Created attachment 377840 [details]
Fix Wincairo
Comment on attachment 377840 [details] Fix Wincairo Clearing flags on attachment: 377840 Committed r249379: <https://trac.webkit.org/changeset/249379> All reviewed patches have been landed. Closing bug. |