Bug 201213 – [Win] Material icons font aren't shown because ligature doesn't work

• Component: Text
• Status: RESOLVED DUPLICATE

[Fujii Hironori]

[Win] Material icons font aren't shown

https://material.io/resources/icons/

[Fujii Hironori]

Created attachment 377425 [details]
test case

[Fujii Hironori]

Created attachment 377426 [details]
test case

It seems that ligature doesn't work.

[Fujii Hironori]

complex text code path can show ligature glyphs properly.

And, DumpRenderTree.exe has --complex-text option.

.\WebKitBuild\Debug\bin64\DumpRenderTree.exe --show-webview --complex-text https://bug-201213-attachments.webkit.org/attachment.cgi?id=377426

[Fujii Hironori]

Created attachment 377432 [details]
WIP patch

[Fujii Hironori]

I found another issue of Windows port, and filed:
Bug 201214 – [Win][UniscribeController] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart

[Myles C. Maxfield]

This looks like a good start.

[Don Olmstead]

Comment on attachment 377432 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377432&action=review

> Source/WebCore/platform/graphics/FontCascade.h:281
> +#if PLATFORM(COCOA) || USE(FREETYPE) || PLATFORM(WIN)

With PLATFORM(WIN) in there that’s everyone so might as well just return true and drop this check.

[Don Olmstead]

(In reply to Fujii Hironori from comment #3)
> complex text code path can show ligature glyphs properly.
> 
> And, DumpRenderTree.exe has --complex-text option.
> 
> .\WebKitBuild\Debug\bin64\DumpRenderTree.exe --show-webview --complex-text
> https://bug-201213-attachments.webkit.org/attachment.cgi?id=377426

I’m reminded of https://bugs.webkit.org/show_bug.cgi?id=179102 Myles

[Myles C. Maxfield]

(In reply to Don Olmstead from comment #8)
> 
> I’m reminded of https://bugs.webkit.org/show_bug.cgi?id=179102 Myles

What I've got in mind is specific to CoreText, but probably wouldn't be too difficult to hook the architecture I've got in mind up to HarfBuzz. I don't know about DirectWrite, though. Possibly.

[Fujii Hironori]

GTK port is always using complex text code path as default.

Bug 183285 – [GTK] Switch to use always complex text code path
Bug 194614 – [WPE][GTK] Clean up handling of WEBKIT_FORCE_COMPLEX_TEXT

[Fujii Hironori]

I confirmed GTK port doen't show the Material icons if I set the env ver WEBKIT_FORCE_COMPLEX_TEXT=0.

[Fujii Hironori]

Created attachment 402978 [details]
[screenshot] layout issues

I found layout issues for this patch.
https://b.hatena.ne.jp/hotentry/it

* unexpected word breaks
* narrow character spaces

[Fujii Hironori]

(In reply to Fujii Hironori from comment #12)
> * unexpected word breaks

Filed: Bug 213691 – [WinCairo][Uniscribe] Katakana texts are unexpectedly wrapped because they don't fit into its own width

[Fujii Hironori]

(In reply to Fujii Hironori from comment #12)
> * narrow character spaces
Filed: Bug 213754 – [WinCairo][Uniscribe] synthetic bold of embedded bitmap font glyphs are placed narrowly in complex text code path

[Fujii Hironori]

Created attachment 403148 [details]
WIP patch

[Fujii Hironori]

Myles is working on it in Bug 215318. Closed as duplicate.

*** This bug has been marked as a duplicate of bug 215318 ***