Bug 201214 – [Win][Uniscribe] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Fujii Hironori]

[Win][UniscribeController] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart

For example, 'accessible_forward' are split as three items (accessible _ forward). Then, 'accessible' icon is shown incorrectly.
'3d_rotation' is split as four items (3 d _ rotation).

https://material.io/resources/icons/

[Fujii Hironori]

Created attachment 377437 [details]
screenshot

[Fujii Hironori]

Google News is also using Material icons.

https://news.google.com/

'star_border' shows 'star' icons.
'directions_bike' shows 'directions' icons.

[Fujii Hironori]

Screenshot of Google News: https://ibb.co/CWqJw7L

[Myles C. Maxfield]

Yikes. Are we calling ScriptItemize incorrectly?

[Fujii Hironori]

[BUG] Webkit font rendering (spacing / icon fonts) · Issue #2626 · microsoft/playwright
https://github.com/microsoft/playwright/issues/2626

[Fujii Hironori]

Playwright's downstream patch: https://github.com/pavelfeldman/webkit/commit/ee5fd605f6d9ea3391317e269ebb5d948e896464

[Fujii Hironori]

Created attachment 404428 [details]
WIP patch

[Fujii Hironori]

Created attachment 404481 [details]
Patch

[Fujii Hironori]

Interestingly, mac and ios testing EWS failed.
I created a ligature font to test the patch.
I don't know this is a Mac bug or my font bug.
I'm going to check it.

[Fujii Hironori]

Created attachment 404547 [details]
Patch

[Fujii Hironori]

Created attachment 404697 [details]
Patch

[Don Olmstead]

Comment on attachment 404697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404697&action=review

r=me with nits

> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:187
> +    if (font->platformData().isSystemFont() || font->platformData().hasVariations())

Will variations never hit this same issue? If not then remove it.

> LayoutTests/ChangeLog:10
> +        * fonts/ligature.woff: Added.

Do you maybe want to add where it came from in case of licensing questions in the future.

[Fujii Hironori]

Comment on attachment 404697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404697&action=review

>> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:187
>> +    if (font->platformData().isSystemFont() || font->platformData().hasVariations())
> 
> Will variations never hit this same issue? If not then remove it.

Will check.

>> LayoutTests/ChangeLog:10
>> +        * fonts/ligature.woff: Added.
> 
> Do you maybe want to add where it came from in case of licensing questions in the future.

Agreed. It was created by me. It contains only ▲ and ■ glyphs.

[Myles C. Maxfield]

Comment on attachment 404697 [details]
Patch

How is this supposed to work? What do non-browser Windows apps do when they want to use material icons?

[Fujii Hironori]

Myles, you are right. ScriptItemize has a option (fMergeNeutralItems) to control it.

https://docs.microsoft.com/en-us/windows/win32/api/usp10/ns-usp10-script_control

[Fujii Hironori]

Created attachment 404893 [details]
Patch

[Fujii Hironori]

Comment on attachment 404893 [details]
Patch

Clearing flags on attachment: 404893

Committed r264722: <https://trac.webkit.org/changeset/264722>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/65951341>