Bug 201191

Summary: Fix applying diffs that only change file mode
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: Tools / TestsAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ddkilzer, dino, ews-watchlist, jbedard, kbr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948, 201156    
Attachments:
Description Flags
Patch none

James Darpinian
Reported 2019-08-27 11:18:44 PDT
Fix applying diffs that only change file mode
Attachments
Patch (1.19 KB, patch)
2019-08-27 11:19 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-08-27 11:19:53 PDT
Created attachment 377356 [details] Patch
James Darpinian
Comment 2 2019-08-27 11:25:54 PDT
See bug 201156 for an example of a patch that fails without this change.
Daniel Bates
Comment 3 2019-08-27 13:03:19 PDT
Comment on attachment 377356 [details] Patch I can't remember if we have tests for svn-apply the actually driver program. Can you please check if we do in Tools/Scripts/webkitperl? If we do then please write a test. Otherwise, this change is fine as-is since we tend not to test the driver code - we test the library code.
Daniel Bates
Comment 4 2019-08-27 13:06:24 PDT
Thanks for the patch!
James Darpinian
Comment 5 2019-08-27 16:44:03 PDT
Thanks for reviewing! I looked but don't see any tests for the svn-apply driver program itself.
Daniel Bates
Comment 6 2019-08-27 19:20:17 PDT
Ok
WebKit Commit Bot
Comment 7 2019-08-27 20:14:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 377356 [details]: fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2019-08-27 20:15:40 PDT
Comment on attachment 377356 [details] Patch Clearing flags on attachment: 377356 Committed r249190: <https://trac.webkit.org/changeset/249190>
WebKit Commit Bot
Comment 9 2019-08-27 20:15:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-08-27 20:16:23 PDT
<rdar://problem/54775598>
Note You need to log in before you can comment on or make changes to this bug.