Bug 201181

Summary: InlineTextBox::end() should return first-past-end offset
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, lantw44, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201645
Bug Depends on:    
Bug Blocks: 210677    
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2019-08-27 08:05:40 PDT
It currently points to the last character, except for empty text boxes. This is awkward in itself and also inconsistent, as we use first-past-end offset everywhere else.
Attachments
patch (12.77 KB, patch)
2019-08-27 08:11 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (14.20 KB, patch)
2019-08-27 08:36 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-08-27 08:11:47 PDT
Created attachment 377340 [details] patch
Antti Koivisto
Comment 2 2019-08-27 08:36:01 PDT
Created attachment 377341 [details] patch
zalan
Comment 3 2019-08-27 11:11:11 PDT
Comment on attachment 377341 [details] patch I wonder what the reasoning was when it was introduced.
WebKit Commit Bot
Comment 4 2019-08-27 12:29:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 377341 [details]: fullscreen/full-screen-request-removed-with-raf.html bug 201188 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-08-27 12:29:59 PDT
Comment on attachment 377341 [details] patch Clearing flags on attachment: 377341 Committed r249160: <https://trac.webkit.org/changeset/249160>
WebKit Commit Bot
Comment 6 2019-08-27 12:30:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-27 12:32:44 PDT
<rdar://problem/54758922>
Note You need to log in before you can comment on or make changes to this bug.