| Summary: | Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 200384, 203300 | ||||||||
| Bug Blocks: | 213632 | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2019-08-26 14:05:26 PDT
We also should introduce an `InspectorBackend.finalize()` (or something like that) so that `InspectorBackend` can release the domains/commands/events that aren't actually being used. It might be worth adding `targetTypes` support to types too. Created attachment 402833 [details]
Patch
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Created attachment 402834 [details]
Patch
oops, forgot to rebase the inspector protocl tests
Comment on attachment 402834 [details]
Patch
r=me
Comment on attachment 402834 [details]
Patch
I don't think we want this to land just yet :)
Oops, I had reviewed but forgot to submit. r=me as well. Awesome! Committed r266072: <https://trac.webkit.org/changeset/266072> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402834 [details]. |