Bug 200970

Summary: [Win][MiniBrowser] Add a progress indicator to the main window
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201541
Attachments:
Description Flags
WIP patch
none
Patch none

Fujii Hironori
Reported 2019-08-21 01:28:01 PDT
[Win][MiniBrowser] Add a progress indicator to the main window
Attachments
WIP patch (12.32 KB, patch)
2019-08-21 01:30 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (18.64 KB, patch)
2019-08-21 03:03 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-08-21 01:30:31 PDT
Created attachment 376854 [details] WIP patch
Fujii Hironori
Comment 2 2019-08-21 03:03:40 PDT
Created attachment 376857 [details] Patch
Fujii Hironori
Comment 3 2019-08-21 03:28:36 PDT
screenshot: https://ibb.co/KjRPZ8X
Fujii Hironori
Comment 4 2019-08-21 18:50:20 PDT
Comment on attachment 376857 [details] Patch Clearing flags on attachment: 376857 Committed r248990: <https://trac.webkit.org/changeset/248990>
Fujii Hironori
Comment 5 2019-08-21 18:50:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-08-21 18:51:19 PDT
<rdar://problem/54582290>
Fujii Hironori
Comment 7 2019-09-08 23:47:08 PDT
Comment on attachment 376857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376857&action=review > Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:142 > + hr = defaultNotificationCenter->addObserver(webHost, _bstr_t(WebViewProgressEstimateChangedNotification), nullptr); I should call removeObserver elsewhere to avoid leakage. I'm going to fix it in Bug 201600.
Note You need to log in before you can comment on or make changes to this bug.