Bug 200970

Summary: [Win][MiniBrowser] Add a progress indicator to the main window
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, don.olmstead, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201541
Attachments:
Description Flags
WIP patch
none
Patch none

Description Fujii Hironori 2019-08-21 01:28:01 PDT 
[Win][MiniBrowser] Add a progress indicator to the main window
Comment 1 Fujii Hironori 2019-08-21 01:30:31 PDT 
Created attachment 376854 [details]
WIP patch
Comment 2 Fujii Hironori 2019-08-21 03:03:40 PDT 
Created attachment 376857 [details]
Patch
Comment 3 Fujii Hironori 2019-08-21 03:28:36 PDT 
screenshot: https://ibb.co/KjRPZ8X
Comment 4 Fujii Hironori 2019-08-21 18:50:20 PDT 
Comment on attachment 376857 [details]
Patch

Clearing flags on attachment: 376857

Committed r248990: <https://trac.webkit.org/changeset/248990>
Comment 5 Fujii Hironori 2019-08-21 18:50:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-21 18:51:19 PDT 
<rdar://problem/54582290>
Comment 7 Fujii Hironori 2019-09-08 23:47:08 PDT 
Comment on attachment 376857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376857&action=review

> Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:142
> +    hr = defaultNotificationCenter->addObserver(webHost, _bstr_t(WebViewProgressEstimateChangedNotification), nullptr);

I should call removeObserver elsewhere to avoid leakage. I'm going to fix it in Bug 201600.