Bug 200882

Summary: Change default value of window.open()'s url argument
Product: WebKit Reporter: Anne van Kesteren <annevk>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, esprehn+autocc, ews-watchlist, kondapallykalyan, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201145    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Anne van Kesteren
Reported 2019-08-19 03:02:03 PDT
Per discussion in https://github.com/whatwg/html/issues/4762.
Attachments
Patch (3.38 KB, patch)
2019-08-26 13:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.38 KB, patch)
2019-08-26 16:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anne van Kesteren
Comment 1 2019-08-19 04:48:03 PDT
There's a test up for review at https://github.com/web-platform-tests/wpt/pull/18536.
Chris Dumez
Comment 2 2019-08-26 13:03:31 PDT
Created attachment 377263 [details] Patch
Ryosuke Niwa
Comment 3 2019-08-26 13:48:54 PDT
Are you updating the patch for trunk?
Chris Dumez
Comment 4 2019-08-26 13:53:20 PDT
(In reply to Ryosuke Niwa from comment #3) > Are you updating the patch for trunk? The patch is fine, the dependency bug just needs to land first.
Ryosuke Niwa
Comment 5 2019-08-26 13:57:45 PDT
Comment on attachment 377263 [details] Patch Ok, please be sure to have the new patch go through EWS to catch any unexpectedly failing tests.
Chris Dumez
Comment 6 2019-08-26 14:07:33 PDT
(In reply to Ryosuke Niwa from comment #5) > Comment on attachment 377263 [details] > Patch > > Ok, please be sure to have the new patch go through EWS to catch any > unexpectedly failing tests. Sure thing, thanks.
Chris Dumez
Comment 7 2019-08-26 16:47:51 PDT
Created attachment 377290 [details] Patch
WebKit Commit Bot
Comment 8 2019-08-26 20:19:13 PDT
Comment on attachment 377290 [details] Patch Clearing flags on attachment: 377290 Committed r249130: <https://trac.webkit.org/changeset/249130>
WebKit Commit Bot
Comment 9 2019-08-26 20:19:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-08-26 20:20:21 PDT
<rdar://problem/54733725>
Note You need to log in before you can comment on or make changes to this bug.