Bug 200403

Summary: uniqueLogIdentifier() should generate a 64-bit identifier
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: New BugsAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206612    
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2019-08-02 14:00:34 PDT
uniqueLogIdentifier() should generate a 64-bit identifier
Attachments
Patch (2.05 KB, patch)
2019-08-02 14:08 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-02 14:00:50 PDT
<rdar://problem/53878447>
Eric Carlson
Comment 2 2019-08-02 14:08:53 PDT
Created attachment 375452 [details] Patch
youenn fablet
Comment 3 2019-08-02 14:18:50 PDT
Comment on attachment 375452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375452&action=review > Source/WTF/ChangeLog:12 > + uint32_t so use two to generate a 64-bit identifier. Maybe we should have a way to print parent id as ABCD and child log identifier as ABCD-EFGH so that it is easier to spot the relationship between parent and child. 32 bits is probably enough for parent ids so that any id above 2^32 would be printed as a child identifier.
Eric Carlson
Comment 4 2019-08-02 14:22:00 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 375452 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375452&action=review > > > Source/WTF/ChangeLog:12 > > + uint32_t so use two to generate a 64-bit identifier. > > Maybe we should have a way to print parent id as ABCD and child log > identifier as ABCD-EFGH so that it is easier to spot the relationship > between parent and child. > 32 bits is probably enough for parent ids so that any id above 2^32 would be > printed as a child identifier. Good idea, I'll think about the best way to do that.
WebKit Commit Bot
Comment 5 2019-08-02 14:54:32 PDT
Comment on attachment 375452 [details] Patch Clearing flags on attachment: 375452 Committed r248183: <https://trac.webkit.org/changeset/248183>
WebKit Commit Bot
Comment 6 2019-08-02 14:54:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.