Bug 200311

Summary: Update TestWebKitAPI for XCBuild
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keith Rollin
Reported 2019-07-31 12:23:38 PDT
Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build technique. Now update WebKitLegacy to build under XCBuild after those changes. This work involves adding an "Apply Configuration to XCFileLists" build target, adding a check-xcfilelists.sh script, adding a "Check xcfilelists" build phase that calls that script, adding knowledge of the project to the generate-xcfilelists script, creating new .xcfilelist files, and adding those to the project.
Attachments
Patch (12.08 KB, patch)
2019-07-31 12:29 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (12.08 KB, patch)
2019-07-31 13:55 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (10.50 KB, patch)
2019-07-31 14:27 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-31 12:23:51 PDT
<rdar://problem/53773804>
Keith Rollin
Comment 2 2019-07-31 12:29:50 PDT
Created attachment 375234 [details] Patch
Keith Rollin
Comment 3 2019-07-31 12:31:36 PDT
Oops. The patch doesn't apply?
Keith Rollin
Comment 4 2019-07-31 12:32:33 PDT
Oh. I know why. Bug 200310 needs to land first.
Keith Rollin
Comment 5 2019-07-31 12:40:24 PDT
FYI, this patch parallels that for Bug 200310.
Keith Rollin
Comment 6 2019-07-31 13:55:02 PDT
Created attachment 375240 [details] Patch
Keith Rollin
Comment 7 2019-07-31 13:55:45 PDT
Bug 200310 has landed, so re-uploaded the patch for this bug for EWS purposes.
Keith Rollin
Comment 8 2019-07-31 13:57:37 PDT
Now what?
Keith Rollin
Comment 9 2019-07-31 14:27:41 PDT
Created attachment 375244 [details] Patch
Keith Rollin
Comment 10 2019-07-31 14:28:04 PDT
OK, I rebased on ToT it locally, so it should apply now.
WebKit Commit Bot
Comment 11 2019-08-01 10:52:07 PDT
Comment on attachment 375244 [details] Patch Clearing flags on attachment: 375244 Committed r248106: <https://trac.webkit.org/changeset/248106>
WebKit Commit Bot
Comment 12 2019-08-01 10:52:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.