Bug 200311

Summary: Update TestWebKitAPI for XCBuild
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Keith Rollin 2019-07-31 12:23:38 PDT 
Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build technique. Now update WebKitLegacy to build under XCBuild after those changes. This work involves adding an "Apply Configuration to XCFileLists" build target, adding a check-xcfilelists.sh script, adding a "Check xcfilelists" build phase that calls that script, adding knowledge of the project to the generate-xcfilelists script, creating new .xcfilelist files, and adding those to the project.
Comment 1 Radar WebKit Bug Importer 2019-07-31 12:23:51 PDT 
<rdar://problem/53773804>
Comment 2 Keith Rollin 2019-07-31 12:29:50 PDT 
Created attachment 375234 [details]
Patch
Comment 3 Keith Rollin 2019-07-31 12:31:36 PDT 
Oops. The patch doesn't apply?
Comment 4 Keith Rollin 2019-07-31 12:32:33 PDT 
Oh. I know why. Bug 200310 needs to land first.
Comment 5 Keith Rollin 2019-07-31 12:40:24 PDT 
FYI, this patch parallels that for Bug 200310.
Comment 6 Keith Rollin 2019-07-31 13:55:02 PDT 
Created attachment 375240 [details]
Patch
Comment 7 Keith Rollin 2019-07-31 13:55:45 PDT 
Bug 200310 has landed, so re-uploaded the patch for this bug for EWS purposes.
Comment 8 Keith Rollin 2019-07-31 13:57:37 PDT 
Now what?
Comment 9 Keith Rollin 2019-07-31 14:27:41 PDT 
Created attachment 375244 [details]
Patch
Comment 10 Keith Rollin 2019-07-31 14:28:04 PDT 
OK, I rebased on ToT it locally, so it should apply now.
Comment 11 WebKit Commit Bot 2019-08-01 10:52:07 PDT 
Comment on attachment 375244 [details]
Patch

Clearing flags on attachment: 375244

Committed r248106: <https://trac.webkit.org/changeset/248106>
Comment 12 WebKit Commit Bot 2019-08-01 10:52:09 PDT 
All reviewed patches have been landed.  Closing bug.