Bug 199994

Summary: [ews-build] Add an EWS to run services tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202864
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Aakash Jain
Reported 2019-07-21 14:46:01 PDT
Add an EWS to run ews unit-tests. This would be to catch any issues in Buildbot configurations.
Attachments
Patch (10.85 KB, patch)
2019-07-21 14:49 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2019-07-21 14:55 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (12.34 KB, patch)
2019-07-22 10:40 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (12.29 KB, patch)
2019-07-22 11:32 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-07-21 14:49:58 PDT
Created attachment 374581 [details] Patch
EWS Watchlist
Comment 2 2019-07-21 14:52:04 PDT Comment hidden (obsolete)
Aakash Jain
Comment 3 2019-07-21 14:55:20 PDT
Created attachment 374582 [details] Patch
EWS Watchlist
Comment 4 2019-07-21 14:57:07 PDT Comment hidden (obsolete)
Aakash Jain
Comment 6 2019-07-21 15:00:45 PDT
Comment on attachment 374582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374582&action=review > Tools/BuildSlaveSupport/ews-build/config.json:445 > + "shortname": "tools", Not sure if that's the best name for the status-bubble for this EWS.
Jonathan Bedard
Comment 7 2019-07-22 07:47:08 PDT
Comment on attachment 374582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374582&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 > + 'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'tools'] Do we intend this form of EWS to include more than just EWS tests? If that's the case, I'd call it 'services'. We could include build.webkit.org tests and resultsdbpy tests too (off the top of my head, these would be the most useful to me personally). >> Tools/BuildSlaveSupport/ews-build/config.json:445 >> + "shortname": "tools", > > Not sure if that's the best name for the status-bubble for this EWS. If we intend this bubble to cover more than just EWS, I think it should be 'services'. Otherwise, I actually thing it should be either 'ews' or 'buildbot-ews'.
Aakash Jain
Comment 8 2019-07-22 09:14:04 PDT
Comment on attachment 374582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374582&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 >> + 'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'tools'] > > Do we intend this form of EWS to include more than just EWS tests? If that's the case, I'd call it 'services'. We could include build.webkit.org tests and resultsdbpy tests too (off the top of my head, these would be the most useful to me personally). Yeah, we should include more tests in this queue. Especially because we already have too many status-bubbles to display in Bugzilla, and would prefer to limit them when possible. I'll rename it to 'services'. Will add build-step for build.webkit.org tests in subsequent patch. Please let me know about how to run resultsdbpy tests. A minor efficiency concern might be there with CheckPatchRelevance step, if a patch is relevant to only one kind of test, we will still run multiple tests on the queue. Which might be fine given that these test are fast anyways. If that actually becomes a concern, we can fix it using doStepIf for the individual tests.
Aakash Jain
Comment 9 2019-07-22 10:40:32 PDT
Created attachment 374604 [details] Patch
EWS Watchlist
Comment 10 2019-07-22 10:42:22 PDT Comment hidden (obsolete)
Jonathan Bedard
Comment 11 2019-07-22 11:13:13 PDT
(In reply to Aakash Jain from comment #8) > Comment on attachment 374582 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374582&action=review > > >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:43 > >> + 'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'tools'] > > > > Do we intend this form of EWS to include more than just EWS tests? If that's the case, I'd call it 'services'. We could include build.webkit.org tests and resultsdbpy tests too (off the top of my head, these would be the most useful to me personally). > > Yeah, we should include more tests in this queue. Especially because we > already have too many status-bubbles to display in Bugzilla, and would > prefer to limit them when possible. I'll rename it to 'services'. Will add > build-step for build.webkit.org tests in subsequent patch. Please let me > know about how to run resultsdbpy tests. > > A minor efficiency concern might be there with CheckPatchRelevance step, if > a patch is relevant to only one kind of test, we will still run multiple > tests on the queue. Which might be fine given that these test are fast > anyways. If that actually becomes a concern, we can fix it using doStepIf > for the individual tests. That efficiency trade-off seems fine. Service tests tend to be fast, and we won't be running these on most patches anyways.
Aakash Jain
Comment 13 2019-07-22 11:32:46 PDT
Created attachment 374613 [details] Patch
WebKit Commit Bot
Comment 14 2019-07-22 12:16:40 PDT
Comment on attachment 374613 [details] Patch Clearing flags on attachment: 374613 Committed r247694: <https://trac.webkit.org/changeset/247694>
WebKit Commit Bot
Comment 15 2019-07-22 12:16:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16 2019-07-22 12:17:15 PDT
<rdar://problem/53410028>
Note You need to log in before you can comment on or make changes to this bug.