Bug 199956

Summary: Move Ref.js to WebKit to support resultsdbpy's frontend
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, jbedard, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Zhifei Fang
Reported 2019-07-19 12:14:28 PDT
https://bugs.webkit.org/show_bug.cgi?id=199837
Attachments
Patch (58.75 KB, patch)
2019-07-19 13:31 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (67.27 KB, patch)
2019-07-19 15:07 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Patch (67.23 KB, patch)
2019-07-19 16:34 PDT, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2019-07-19 13:31:08 PDT
Created attachment 374491 [details] Patch
Jonathan Bedard
Comment 2 2019-07-19 13:46:51 PDT
Comment on attachment 374491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374491&action=review > Tools/ChangeLog:3 > + Move Ref.js to opensource to support resultsdbpy's frontend Can we hook-up the resultsdbpy stuff while we're at it? We also need to decide if these will be accessed with: https://results.webkit.org/library/Ref.js (current behavior) https://results.webkit.org/library/js/Ref.js
Zhifei Fang
Comment 3 2019-07-19 15:07:10 PDT
Created attachment 374500 [details] Patch
Jonathan Bedard
Comment 4 2019-07-19 15:11:22 PDT
Comment on attachment 374500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374500&action=review > Tools/resultsdbpy/resultsdbpy/view/view_routes.py:-113 > - AssertRequest.is_type() We want to keep these asserts. This basically ensures that the request is a GET request with no queries, since anything else would be invalid.
Zhifei Fang
Comment 5 2019-07-19 16:34:12 PDT
Created attachment 374523 [details] Patch
WebKit Commit Bot
Comment 6 2019-07-19 18:15:32 PDT
Comment on attachment 374523 [details] Patch Clearing flags on attachment: 374523 Committed r247664: <https://trac.webkit.org/changeset/247664>
WebKit Commit Bot
Comment 7 2019-07-19 18:15:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-07-19 18:17:31 PDT
<rdar://problem/53333184>
Note You need to log in before you can comment on or make changes to this bug.