| Summary: | Move Ref.js to WebKit to support resultsdbpy's frontend | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zhifei Fang <zhifei_fang> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, jbedard, webkit-bug-importer, zhifei_fang | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Safari Technology Preview | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Zhifei Fang
2019-07-19 12:14:28 PDT
Created attachment 374491 [details]
Patch
Comment on attachment 374491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374491&action=review > Tools/ChangeLog:3 > + Move Ref.js to opensource to support resultsdbpy's frontend Can we hook-up the resultsdbpy stuff while we're at it? We also need to decide if these will be accessed with: https://results.webkit.org/library/Ref.js (current behavior) https://results.webkit.org/library/js/Ref.js Created attachment 374500 [details]
Patch
Comment on attachment 374500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374500&action=review > Tools/resultsdbpy/resultsdbpy/view/view_routes.py:-113 > - AssertRequest.is_type() We want to keep these asserts. This basically ensures that the request is a GET request with no queries, since anything else would be invalid. Created attachment 374523 [details]
Patch
Comment on attachment 374523 [details] Patch Clearing flags on attachment: 374523 Committed r247664: <https://trac.webkit.org/changeset/247664> All reviewed patches have been landed. Closing bug. |