Summary: | Add runtime flag for lazy image loading | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||||||||
Component: | Images | Assignee: | Rob Buis <rbuis> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, jonlee, kondapallykalyan, sabouhallawa, simon.fraser, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | Other | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 196698 | ||||||||||||||||
Attachments: |
|
Description
Rob Buis
2019-07-15 01:27:19 PDT
Created attachment 374107 [details]
Patch
Created attachment 374108 [details]
Patch
Created attachment 375406 [details]
Patch
Comment on attachment 375406 [details]
Patch
OK. Wow this sure is a long way from "just add it to a list in one place". The WebKitLegacy part is particularly huge and ugly. Ironic because it’s not used by Safari.
I was going to say review+, but wait, where is the part that makes this work in WebKitTestRunner for modern WebKit?
Created attachment 375526 [details]
Patch
(In reply to Darin Adler from comment #4) > Comment on attachment 375406 [details] > Patch > > OK. Wow this sure is a long way from "just add it to a list in one place". > The WebKitLegacy part is particularly huge and ugly. Ironic because it’s not > used by Safari. It is a lot of work and easy to miss things. At least having dealt with it in the past, it is a little easier now. > I was going to say review+, but wait, where is the part that makes this work > in WebKitTestRunner for modern WebKit? Good catch, I added the TestOption in WebKitTestRunner. Created attachment 375796 [details]
Patch
Comment on attachment 375796 [details] Patch Clearing flags on attachment: 375796 Committed r248409: <https://trac.webkit.org/changeset/248409> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 378162 [details]
Patch
Comment on attachment 378162 [details] Patch Clearing flags on attachment: 378162 Committed r249571: <https://trac.webkit.org/changeset/249571> All reviewed patches have been landed. Closing bug. |