Bug 199550

Summary: Web Inspector: Debugger: there should be a different icon for URL breakpoints
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199552
https://bugs.webkit.org/show_bug.cgi?id=199554
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Patch
none
[Image] After Patch is applied none

Description Devin Rousso 2019-07-06 11:18:10 PDT 
Using the "source" icon [=] is weird, especially since all other breakpoint types have an icon.  I'd imagine that it would be something like a [U] (for URL) or [C] (for containing) and [M] (for matching).
Comment 1 Devin Rousso 2019-07-06 12:36:52 PDT 
Created attachment 373575 [details]
Patch
Comment 2 Devin Rousso 2019-07-06 12:37:05 PDT 
Created attachment 373576 [details]
[Image] After Patch is applied
Comment 3 Devin Rousso 2019-07-08 15:15:41 PDT 
Created attachment 373669 [details]
Patch

Extend the "tails" of the arrows to the edge of the box.
Comment 4 Devin Rousso 2019-07-08 15:18:59 PDT 
Created attachment 373671 [details]
[Image] After Patch is applied
Comment 5 Joseph Pecoraro 2019-07-08 15:25:22 PDT 
Comment on attachment 373669 [details]
Patch

Looks good! r=me
Comment 6 WebKit Commit Bot 2019-07-08 16:49:17 PDT 
Comment on attachment 373669 [details]
Patch

Clearing flags on attachment: 373669

Committed r247237: <https://trac.webkit.org/changeset/247237>
Comment 7 WebKit Commit Bot 2019-07-08 16:49:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-08 16:50:24 PDT 
<rdar://problem/52804997>