Bug 199550

Summary: Web Inspector: Debugger: there should be a different icon for URL breakpoints
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199552
https://bugs.webkit.org/show_bug.cgi?id=199554
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Patch
none
[Image] After Patch is applied none

Devin Rousso
Reported 2019-07-06 11:18:10 PDT
Using the "source" icon [=] is weird, especially since all other breakpoint types have an icon. I'd imagine that it would be something like a [U] (for URL) or [C] (for containing) and [M] (for matching).
Attachments
Patch (7.22 KB, patch)
2019-07-06 12:36 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (89.81 KB, image/png)
2019-07-06 12:37 PDT, Devin Rousso 		no flags
Details
Patch (7.27 KB, patch)
2019-07-08 15:15 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (801.28 KB, image/png)
2019-07-08 15:18 PDT, Devin Rousso 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-07-06 12:36:52 PDT
Created attachment 373575 [details] Patch
Devin Rousso
Comment 2 2019-07-06 12:37:05 PDT
Created attachment 373576 [details] [Image] After Patch is applied
Devin Rousso
Comment 3 2019-07-08 15:15:41 PDT
Created attachment 373669 [details] Patch Extend the "tails" of the arrows to the edge of the box.
Devin Rousso
Comment 4 2019-07-08 15:18:59 PDT
Created attachment 373671 [details] [Image] After Patch is applied
Joseph Pecoraro
Comment 5 2019-07-08 15:25:22 PDT
Comment on attachment 373669 [details] Patch Looks good! r=me
WebKit Commit Bot
Comment 6 2019-07-08 16:49:17 PDT
Comment on attachment 373669 [details] Patch Clearing flags on attachment: 373669 Committed r247237: <https://trac.webkit.org/changeset/247237>
WebKit Commit Bot
Comment 7 2019-07-08 16:49:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-07-08 16:50:24 PDT
<rdar://problem/52804997>
Note You need to log in before you can comment on or make changes to this bug.