Bug 199549

Summary: Enabling the Layers tab hides the paint flashing button
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, ross.kirsling, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2019-07-06 11:01:13 PDT
If you enable the Layers tab, the paint flashing button (the little paintbrush) disappears from the Elements tab.
Attachments
Patch (2.55 KB, patch)
2019-07-06 13:18 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-07-06 11:22:38 PDT
The toggles for Paint Flashing and Compositing Borders are moved to the Layers tab when its enabled. Personally, I think that the Layers details sidebar (which is still shown in the Elements tab) should also move to the Layers tab, but there's been back and forth on that in the past.
Simon Fraser (smfr)
Comment 2 2019-07-06 11:26:30 PDT
It's _very_ confusing when enabling a tab moves buttons around. Can we just leave the old UI alone?
Simon Fraser (smfr)
Comment 3 2019-07-06 11:26:46 PDT
Also what does paint flashing have to do with layers.
Devin Rousso
Comment 4 2019-07-06 13:18:32 PDT
Created attachment 373580 [details] Patch
Joseph Pecoraro
Comment 5 2019-07-08 14:50:01 PDT
Comment on attachment 373580 [details] Patch r=me
Ross Kirsling
Comment 6 2019-07-08 14:57:21 PDT
The original idea was that the Layers sidebar would be *replaced* by the Layers tab, and so these buttons were going to be migrated over as well. We went back on this idea in bug 190158, so it seems that this part was just missed from that patch.
WebKit Commit Bot
Comment 7 2019-07-08 19:19:32 PDT
Comment on attachment 373580 [details] Patch Clearing flags on attachment: 373580 Committed r247248: <https://trac.webkit.org/changeset/247248>
WebKit Commit Bot
Comment 8 2019-07-08 19:19:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-07-08 19:20:25 PDT
<rdar://problem/52810669>
Note You need to log in before you can comment on or make changes to this bug.