Bug 190158 - Web Inspector: make the layers sidebar in the Elements tab always visible
Summary: Web Inspector: make the layers sidebar in the Elements tab always visible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-01 14:23 PDT by Devin Rousso
Modified: 2018-10-30 13:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2018-10-25 10:38 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (1.30 MB, image/png)
2018-10-25 10:38 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-01 14:23:19 PDT
Instead of removing the Layers sidebar when the Layers tab is enabled, we should always show the Layers sidebar.  There is still utility in showing layer information for a specific node.  The Layers tab is more for a page-level visualization.
Comment 1 Devin Rousso 2018-10-25 10:38:10 PDT
Created attachment 353092 [details]
Patch
Comment 2 Devin Rousso 2018-10-25 10:38:37 PDT
Created attachment 353093 [details]
[Image] After Patch is applied
Comment 3 Ross Kirsling 2018-10-25 13:14:18 PDT
Seems good as long as nobody's worried about the Layers sidebar not being the exactly the same as the Layers tab sidebar.

(It is, after all, quite possible that I was the only one ever worried about that... 😅)
Comment 4 BJ Burg 2018-10-30 12:53:11 PDT
Comment on attachment 353092 [details]
Patch

r=me 

In the short term this seems fine, as Layers tab still has some key functionality missing. In the longer term I think a context menu action per-node would be sufficient for localizing a node's layer.
Comment 5 Ross Kirsling 2018-10-30 13:04:29 PDT
(In reply to Brian Burg from comment #4)
> ... In the longer term I think a context menu action
> per-node would be sufficient for localizing a node's layer.

We do have that thanks to Devin's earlier work :)
https://bugs.webkit.org/show_bug.cgi?id=181800
Comment 6 WebKit Commit Bot 2018-10-30 13:23:53 PDT
Comment on attachment 353092 [details]
Patch

Clearing flags on attachment: 353092

Committed r237599: <https://trac.webkit.org/changeset/237599>
Comment 7 WebKit Commit Bot 2018-10-30 13:23:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-30 13:53:21 PDT
<rdar://problem/45679555>