Bug 199549 - Enabling the Layers tab hides the paint flashing button
Summary: Enabling the Layers tab hides the paint flashing button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-06 11:01 PDT by Simon Fraser (smfr)
Modified: 2019-07-08 19:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2019-07-06 13:18 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-07-06 11:01:13 PDT
If you enable the Layers tab, the paint flashing button (the little paintbrush) disappears from the Elements tab.
Comment 1 Devin Rousso 2019-07-06 11:22:38 PDT
The toggles for Paint Flashing and Compositing Borders are moved to the Layers tab when its enabled.

Personally, I think that the Layers details sidebar (which is still shown in the Elements tab) should also move to the Layers tab, but there's been back and forth on that in the past.
Comment 2 Simon Fraser (smfr) 2019-07-06 11:26:30 PDT
It's _very_ confusing when enabling a tab moves buttons around. Can we just leave the old UI alone?
Comment 3 Simon Fraser (smfr) 2019-07-06 11:26:46 PDT
Also what does paint flashing have to do with layers.
Comment 4 Devin Rousso 2019-07-06 13:18:32 PDT
Created attachment 373580 [details]
Patch
Comment 5 Joseph Pecoraro 2019-07-08 14:50:01 PDT
Comment on attachment 373580 [details]
Patch

r=me
Comment 6 Ross Kirsling 2019-07-08 14:57:21 PDT
The original idea was that the Layers sidebar would be *replaced* by the Layers tab, and so these buttons were going to be migrated over as well.

We went back on this idea in bug 190158, so it seems that this part was just missed from that patch.
Comment 7 WebKit Commit Bot 2019-07-08 19:19:32 PDT
Comment on attachment 373580 [details]
Patch

Clearing flags on attachment: 373580

Committed r247248: <https://trac.webkit.org/changeset/247248>
Comment 8 WebKit Commit Bot 2019-07-08 19:19:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-07-08 19:20:25 PDT
<rdar://problem/52810669>