Bug 199405

Summary:

[ews-build] Do not print worker environment variables in each build step [part 2]

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dean_johnson, ews-watchlist, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=197319
https://bugs.webkit.org/show_bug.cgi?id=202698

Attachments:

Description	Flags
Patch	none

Aakash Jain

Reported 2019-07-02 08:26:44 PDT

By default Buildbot prints worker's environment variables in each build step. This is unnecessary and makes the logs hard to read. We should disable printing environment variable in most of the build steps. This is part 2 of https://bugs.webkit.org/show_bug.cgi?id=197319

Attachments
Patch (12.59 KB, patch) 2019-07-02 08:29 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-07-02 08:29:10 PDT

Created attachment 373323 [details] Patch

EWS Watchlist

Comment 2 2019-07-02 08:30:24 PDT Comment hidden (obsolete)

Attachment 373323 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:117: [CheckOutSpecificRevision.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:139: [CleanWorkingDirectory.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:622: [CompileWebKit.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1131: [ArchiveTestResults.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Bedard

Comment 3 2019-07-02 11:41:28 PDT

Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference.

Aakash Jain

Comment 4 2019-07-02 11:51:57 PDT

(In reply to Jonathan Bedard from comment #3) > Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference. https://ews-build.webkit.org/#/builders/13/builds/4477/steps/8/logs/stdio vs https://ews-build.webkit-uat.org/#/builders/7/builds/429/steps/9/logs/stdio Similarly, from https://bugs.webkit.org/show_bug.cgi?id=197319: https://ews-build.webkit.org/#/builders/9/builds/1071/steps/5/logs/stdio vs https://ews-build.webkit.org/#/builders/9/builds/3925/steps/6/logs/stdio

WebKit Commit Bot

Comment 5 2019-07-02 12:51:56 PDT

Comment on attachment 373323 [details] Patch Clearing flags on attachment: 373323 Committed r247069: <https://trac.webkit.org/changeset/247069>

WebKit Commit Bot

Comment 6 2019-07-02 12:51:57 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-07-02 12:52:18 PDT

<rdar://problem/52540408>

Note You need to log in before you can comment on or make changes to this bug.