| Summary: | [ews-build] Do not print worker environment variables in each build step [part 2] | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dean_johnson, ews-watchlist, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=197319 https://bugs.webkit.org/show_bug.cgi?id=202698 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-07-02 08:26:44 PDT
Created attachment 373323 [details]
Patch
Attachment 373323 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:117: [CheckOutSpecificRevision.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:139: [CleanWorkingDirectory.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:622: [CompileWebKit.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1131: [ArchiveTestResults.__init__] Use of super on an old style class [pylint/E1002] [5]
Total errors found: 4 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference. (In reply to Jonathan Bedard from comment #3) > Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference. https://ews-build.webkit.org/#/builders/13/builds/4477/steps/8/logs/stdio vs https://ews-build.webkit-uat.org/#/builders/7/builds/429/steps/9/logs/stdio Similarly, from https://bugs.webkit.org/show_bug.cgi?id=197319: https://ews-build.webkit.org/#/builders/9/builds/1071/steps/5/logs/stdio vs https://ews-build.webkit.org/#/builders/9/builds/3925/steps/6/logs/stdio Comment on attachment 373323 [details] Patch Clearing flags on attachment: 373323 Committed r247069: <https://trac.webkit.org/changeset/247069> All reviewed patches have been landed. Closing bug. |