Bug 199078

Summary: test-webkitpy is broken on macOS Catalina
Product: WebKit Reporter: Dean Johnson <dean_johnson>
Component: Tools / TestsAssignee: Dean Johnson <dean_johnson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dean_johnson, ews-feeder, ews-watchlist, glenn, Hironori.Fujii, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199428
Attachments:
Description Flags
Patch none

Description Dean Johnson 2019-06-20 13:48:34 PDT
Building for lldb webkitpy tests fails.
Comment 1 Dean Johnson 2019-06-20 14:04:01 PDT
Created attachment 372581 [details]
Patch
Comment 2 EWS 2019-06-20 15:25:12 PDT
Comment on attachment 372581 [details]
Patch

Rejecting attachment 372581 [details] from commit-queue.

dean_johnson@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Dean Johnson 2019-06-20 15:27:15 PDT
<rdar://problem/51853557>
Comment 4 WebKit Commit Bot 2019-06-20 16:13:06 PDT
Comment on attachment 372581 [details]
Patch

Clearing flags on attachment: 372581

Committed r246662: <https://trac.webkit.org/changeset/246662>
Comment 5 WebKit Commit Bot 2019-06-20 16:13:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-06-20 16:14:17 PDT
<rdar://problem/51964923>
Comment 7 Fujii Hironori 2019-07-02 19:17:16 PDT
Windows port are failing.
Filed:  Bug 199428 – [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'