Bug 199025

Summary: [ews-build] Add step to analyze Compile WebKit failures
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197850
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2019-06-19 12:25:37 PDT
Currently when a patch fails to build, we un-apply the patch, and build without patch. However, we do not analyze the results. We should add a step to analyze these results. Also when ToT fails to build, instead of marking the patch as failed, we should keep trying indefinitely (like old EWS) until ToT is green again.
Attachments
Proposed patch (3.32 KB, patch)
2019-06-19 12:35 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-06-19 12:35:54 PDT
Created attachment 372485 [details] Proposed patch Sample run: Without failure on ToT: https://ews-build.webkit-uat.org/#/builders/33/builds/4178 With failure on ToT: https://ews-build.webkit-uat.org/#/builders/33/builds/4182
Aakash Jain
Comment 2 2019-06-19 12:40:25 PDT
Example of similar behavior on old EWS: https://webkit-queues.webkit.org/patch/369760/mac-wk2-ews
WebKit Commit Bot
Comment 3 2019-06-19 13:49:13 PDT
Comment on attachment 372485 [details] Proposed patch Clearing flags on attachment: 372485 Committed r246609: <https://trac.webkit.org/changeset/246609>
WebKit Commit Bot
Comment 4 2019-06-19 13:49:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-06-19 13:50:20 PDT
<rdar://problem/51911524>
Note You need to log in before you can comment on or make changes to this bug.