Bug 198944 – Web Inspector: Elements: remove ellipses from "Break on" context menu item title

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Per Apple's HI guidelines:

Menu Item Titles
A menu item title describes an action or attribute.

Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice.

See: https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/

Notes:
I don't believe that the above description of "additional input" or a "separate window" applies to submenus.

[Matt Baker]

Created attachment 372298 [details]
Patch

[Matt Baker]

(In reply to Matt Baker from comment #0)
> Per Apple's HI guidelines:
> 
> Menu Item Titles
> A menu item title describes an action or attribute.
> 
> Use an ellipsis whenever choosing a menu item requires additional input from
> the user. The ellipsis character (…) means a dialog or separate window will
> open and prompt the user for additional information or to make a choice.
> 
> See:
> https://developer.apple.com/design/human-interface-guidelines/macos/menus/
> menu-anatomy/
> 
> Notes:
> I don't believe that the above description of "additional input" or a
> "separate window" applies to submenus.

It just occurred to me that the arrow (">") glyph displayed in macOS menu item titles implies this, making the ellipses redundant.

[Radar WebKit Bug Importer]

<rdar://problem/51829232>

[Nikita Vasilyev]

Good find! I was wondering about these ellipses.

[Devin Rousso]

Comment on attachment 372298 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 372298 [details]
Patch

Clearing flags on attachment: 372298

Committed r246532: <https://trac.webkit.org/changeset/246532>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.