Summary: | Web Inspector: Elements: remove ellipses from "Break on" context menu item title | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=198937 | ||||||
Attachments: |
|
Description
Matt Baker
2019-06-17 17:15:44 PDT
Created attachment 372298 [details]
Patch
(In reply to Matt Baker from comment #0) > Per Apple's HI guidelines: > > Menu Item Titles > A menu item title describes an action or attribute. > > Use an ellipsis whenever choosing a menu item requires additional input from > the user. The ellipsis character (…) means a dialog or separate window will > open and prompt the user for additional information or to make a choice. > > See: > https://developer.apple.com/design/human-interface-guidelines/macos/menus/ > menu-anatomy/ > > Notes: > I don't believe that the above description of "additional input" or a > "separate window" applies to submenus. It just occurred to me that the arrow (">") glyph displayed in macOS menu item titles implies this, making the ellipses redundant. Good find! I was wondering about these ellipses. Comment on attachment 372298 [details]
Patch
r=me
Comment on attachment 372298 [details] Patch Clearing flags on attachment: 372298 Committed r246532: <https://trac.webkit.org/changeset/246532> All reviewed patches have been landed. Closing bug. |