Bug 198937

Summary: Web Inspector: Elements: add/edit/copy/delete menus should have a "..." in the label
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED INVALID    
Severity: Normal CC: hi, inspector-bugzilla-changes, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198944
Attachments:
Description Flags
Patch
none
Patch
mattbaker: review-
[Image] After Patch is applied none

Devin Rousso
Reported 2019-06-17 16:26:13 PDT
This matches the "Break on..." and makes it even clearer that you're supposed to click on one of the items in the submenu.
Attachments
Patch (7.15 KB, patch)
2019-06-17 16:32 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2019-06-17 16:33 PDT, Devin Rousso 		mattbaker: review-
DetailsFormatted DiffDiff
[Image] After Patch is applied (310.39 KB, image/png)
2019-06-17 16:40 PDT, Devin Rousso 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-17 16:32:26 PDT
Created attachment 372290 [details] Patch
Devin Rousso
Comment 2 2019-06-17 16:33:32 PDT
Created attachment 372292 [details] Patch
Devin Rousso
Comment 3 2019-06-17 16:40:39 PDT
Created attachment 372293 [details] [Image] After Patch is applied
Matt Baker
Comment 4 2019-06-17 17:08:39 PDT
Comment on attachment 372292 [details] Patch This goes against Apple's HI Guidelines (which I clearly didn't check before adding the "Break on..." context menu item). Here is the relevant documentation: [Copied from https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/] Menu Item Titles A menu item title describes an action or attribute. Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice.
Matt Baker
Comment 5 2019-06-17 17:19:13 PDT
I've put up a patch to address the "Break on..." menu item title: https://bugs.webkit.org/show_bug.cgi?id=198944
Note You need to log in before you can comment on or make changes to this bug.