| Summary: | [iOS] Split up fast/events/ios/key-events-meta-alt-combinations.html and add more tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, bfulgham, ews-watchlist, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | iOS 12 | ||||||||
| Bug Depends on: | 198851 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2019-06-13 09:58:34 PDT
Created attachment 372061 [details]
Patch
I should add that I also rebased the test result for key-events-meta.html now that we map Command + . to Escape following the fix in bug #198137. (We'll see if the bots agree with this change as I think it may require some UIKit bits as well) Comment on attachment 372061 [details] Patch Attachment 372061 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12466494 New failing tests: http/tests/media/video-error-abort.html Created attachment 372072 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Failure can't be caused by this page (famous last words™). I'm just adding more tests. (In reply to Daniel Bates from comment #6) > Failure can't be caused by this page (famous last words™). I'm just adding > more tests. *patch (In reply to Daniel Bates from comment #6) > Failure can't be caused by this page (famous last words™). I'm just adding > more tests. Mac-debug doesn't pass before your patch, so its' not related. Comment on attachment 372061 [details]
Patch
r=me. Hope this improves things!
I am ***not*** going to land this patch until bug #198851 is resolved, a satisfactory answer is given, or I am demanded to land this patch. (In reply to Daniel Bates from comment #10) > I am ***not*** going to land this patch until bug #198851 is resolved, a > satisfactory answer is given, or I am demanded to land this patch. EWS has processed this patch. Please feel free to land it. Comment on attachment 372061 [details] Patch Clearing flags on attachment: 372061 Committed r246450: <https://trac.webkit.org/changeset/246450> All reviewed patches have been landed. Closing bug. |