Bug 198613

Summary: Remove obsolete TOOLCHAINS overrides from asan.xcconfig
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, krollin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198589
https://bugs.webkit.org/show_bug.cgi?id=198586
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-06-06 10:09:42 PDT
We already removed the changes in https://trac.webkit.org/changeset/177746/webkit for every thing except for ASan.
Attachments
Patch (1.20 KB, patch)
2019-06-06 10:20 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.23 KB, patch)
2019-06-06 11:12 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-06-06 10:20:00 PDT
Created attachment 371507 [details] Patch
Jonathan Bedard
Comment 2 2019-06-06 10:20:52 PDT
Probably more accurate to say we're removing <https://trac.webkit.org/changeset/177703/webkit>.
Alexey Proskuryakov
Comment 3 2019-06-06 10:38:27 PDT
Comment on attachment 371507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371507&action=review > Tools/ChangeLog:3 > + Use default toolchain in ASan xcconfig I would call this "remove obsolete TOOLCHAINS overrides from asan.xcconfig". Unfortunately, "default" has two distinct meanings in this context - one is "default", and another what Xcode defaults to. As you can see, older OSes required changing the default to "default".
Jonathan Bedard
Comment 4 2019-06-06 11:12:20 PDT
Created attachment 371511 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-06-06 11:54:50 PDT
Comment on attachment 371511 [details] Patch for landing Clearing flags on attachment: 371511 Committed r246161: <https://trac.webkit.org/changeset/246161>
WebKit Commit Bot
Comment 6 2019-06-06 11:54:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-06-06 11:55:16 PDT
<rdar://problem/51493464>
Note You need to log in before you can comment on or make changes to this bug.