| Summary: | Remove obsolete TOOLCHAINS overrides from asan.xcconfig | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, krollin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=198589 https://bugs.webkit.org/show_bug.cgi?id=198586 |
||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2019-06-06 10:09:42 PDT
Created attachment 371507 [details]
Patch
Probably more accurate to say we're removing <https://trac.webkit.org/changeset/177703/webkit>. Comment on attachment 371507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371507&action=review > Tools/ChangeLog:3 > + Use default toolchain in ASan xcconfig I would call this "remove obsolete TOOLCHAINS overrides from asan.xcconfig". Unfortunately, "default" has two distinct meanings in this context - one is "default", and another what Xcode defaults to. As you can see, older OSes required changing the default to "default". Created attachment 371511 [details]
Patch for landing
Comment on attachment 371511 [details] Patch for landing Clearing flags on attachment: 371511 Committed r246161: <https://trac.webkit.org/changeset/246161> All reviewed patches have been landed. Closing bug. |