Bug 19861

Summary: CSSTransformList should be WebKitCSSTransformList
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 19028, 19863    
Attachments:
Description Flags
Patch to rename CSSTransformValue and change inheritance hyatt: review+

Dean Jackson
Reported 2008-07-02 16:18:11 PDT
The CSSTransformList class should be named WebKitCSSTransformList (the same as the DOM interface to come in a subsequent patch). It should also inherit from CSSValueList rather than CSSValue.
Attachments
Patch to rename CSSTransformValue and change inheritance (39.58 KB, patch)
2008-07-02 16:19 PDT, Dean Jackson 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2008-07-02 16:19:25 PDT
Created attachment 22053 [details] Patch to rename CSSTransformValue and change inheritance This should also change the build for all platforms
Dean Jackson
Comment 2 2008-07-02 16:50:36 PDT
oops - line 36 of WebKitCSSTransformValue.cpp should be CSSValueList(false)
Dean Jackson
Comment 3 2008-07-02 18:58:04 PDT
forget the oops - the patch is correct. The transform list should be space separated, not comma.
Dave Hyatt
Comment 4 2008-07-08 11:14:08 PDT
Comment on attachment 22053 [details] Patch to rename CSSTransformValue and change inheritance r=me
Dean Jackson
Comment 5 2008-07-09 17:28:16 PDT
Done in 35081 http://trac.webkit.org/changeset/35081
Note You need to log in before you can comment on or make changes to this bug.