| Summary: | webkitpy: Support ASan as a style | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, commit-queue, ews-watchlist, glenn, keith_miller, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=198613 https://bugs.webkit.org/show_bug.cgi?id=198589 |
||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2019-06-05 15:52:41 PDT
This will need <https://bugs.webkit.org/show_bug.cgi?id=198589> to land first. Created attachment 371454 [details]
Patch
We can't actually do the buildbot changes for this to be used until we fix the Asan build (originally <https://bugs.webkit.org/show_bug.cgi?id=198589>, but now we're going to do <https://bugs.webkit.org/show_bug.cgi?id=198613>). But, this change is safe to land, it has no effect on building. Comment on attachment 371454 [details] Patch Rejecting attachment 371454 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 371454, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12396876 Created attachment 371509 [details]
Patch for landing
Comment on attachment 371509 [details] Patch for landing Clearing flags on attachment: 371509 Committed r246159: <https://trac.webkit.org/changeset/246159> All reviewed patches have been landed. Closing bug. |