Bug 198586

Summary:

webkitpy: Support ASan as a style

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, keith_miller, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=198613
https://bugs.webkit.org/show_bug.cgi?id=198589

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Jonathan Bedard

Reported 2019-06-05 15:52:41 PDT

Our configuration scripts support ASan, run-webkit-tests just isn't smart enough to consume it.

Attachments
Patch (4.60 KB, patch) 2019-06-05 17:11 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch for landing (4.61 KB, patch) 2019-06-06 11:01 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-06-05 15:53:19 PDT

<rdar://problem/51459088>

Jonathan Bedard

Comment 2 2019-06-05 17:08:27 PDT

This will need <https://bugs.webkit.org/show_bug.cgi?id=198589> to land first.

Jonathan Bedard

Comment 3 2019-06-05 17:11:44 PDT

Created attachment 371454 [details] Patch

Jonathan Bedard

Comment 4 2019-06-06 10:22:54 PDT

We can't actually do the buildbot changes for this to be used until we fix the Asan build (originally <https://bugs.webkit.org/show_bug.cgi?id=198589>, but now we're going to do <https://bugs.webkit.org/show_bug.cgi?id=198613>). But, this change is safe to land, it has no effect on building.

WebKit Commit Bot

Comment 5 2019-06-06 10:24:02 PDT

Comment on attachment 371454 [details] Patch Rejecting attachment 371454 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 371454, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12396876

Jonathan Bedard

Comment 6 2019-06-06 11:01:59 PDT

Created attachment 371509 [details] Patch for landing

WebKit Commit Bot

Comment 7 2019-06-06 11:44:10 PDT

Comment on attachment 371509 [details] Patch for landing Clearing flags on attachment: 371509 Committed r246159: <https://trac.webkit.org/changeset/246159>

WebKit Commit Bot

Comment 8 2019-06-06 11:44:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.