Bug 198463

Summary: Remove include directives unused since r245186
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit2Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, don.olmstead, ews-watchlist, fujii.hironori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews211 for win-future none

Konstantin Tokarev
Reported 2019-06-01 15:22:25 PDT
Remove include directives in NetworkCacheBlobStorage.cpp unused since r245186
Attachments
Patch (1.20 KB, patch)
2019-06-01 15:23 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2019-06-01 15:36 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews211 for win-future (14.25 MB, application/zip)
2019-06-01 18:23 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2019-06-01 15:23:57 PDT
Created attachment 371123 [details] Patch
Konstantin Tokarev
Comment 2 2019-06-01 15:36:22 PDT
Created attachment 371125 [details] Patch
Konstantin Tokarev
Comment 3 2019-06-01 15:57:18 PDT
It seems wrong that while OS(WINDOWS) conditional compilation was removed from NetworkCacheBlobStorage.cpp, common code is using POSIX functions stat() and unlink(). Apparently they are used on Windows without including their headers
EWS Watchlist
Comment 4 2019-06-01 18:23:54 PDT
Comment on attachment 371125 [details] Patch Attachment 371125 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12351821 New failing tests: storage/indexeddb/modern/get-keyrange.html
EWS Watchlist
Comment 5 2019-06-01 18:23:57 PDT
Created attachment 371136 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
WebKit Commit Bot
Comment 6 2019-06-01 20:02:07 PDT
Comment on attachment 371125 [details] Patch Clearing flags on attachment: 371125 Committed r246020: <https://trac.webkit.org/changeset/246020>
WebKit Commit Bot
Comment 7 2019-06-01 20:02:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-06-01 20:03:19 PDT
<rdar://problem/51335245>
Fujii Hironori
Comment 9 2019-06-02 20:23:16 PDT
(In reply to Konstantin Tokarev from comment #3) > It seems wrong that while OS(WINDOWS) conditional compilation was removed > from NetworkCacheBlobStorage.cpp, common code is using POSIX functions > stat() and unlink(). Apparently they are used on Windows without including > their headers Filed in Bug 198473.
Note You need to log in before you can comment on or make changes to this bug.