Bug 198122

Summary: Remove the non final propertyRegistry() from the SVG base classes
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW    
Severity: Normal CC: ews-watchlist, zimmermann
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192519, 198073    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for review sabouhallawa: review?

Said Abou-Hallawa
Reported 2019-05-22 09:00:19 PDT
This saves the memory that is taken by the member SVGPropertyRegistry of the base class. propertyRegistry() is only needed for concrete classes.
Attachments
Patch (294.03 KB, patch)
2019-05-22 09:04 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (309.36 KB, patch)
2019-05-23 08:12 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (308.65 KB, patch)
2019-06-08 14:55 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (97.76 KB, patch)
2019-06-08 18:12 PDT, Said Abou-Hallawa 		sabouhallawa: review?
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-05-22 09:04:00 PDT
Created attachment 370400 [details] Patch
EWS Watchlist
Comment 2 2019-05-22 09:07:25 PDT
Attachment 370400 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 144 files If any of these errors are false positives, please file a bug against check-webkit-style.
Said Abou-Hallawa
Comment 3 2019-05-23 08:12:58 PDT
Created attachment 370506 [details] Patch
Said Abou-Hallawa
Comment 4 2019-06-08 14:55:25 PDT
Created attachment 371669 [details] Patch
EWS Watchlist
Comment 5 2019-06-08 14:57:07 PDT
Attachment 371669 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGFETurbulenceElement.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 155 files If any of these errors are false positives, please file a bug against check-webkit-style.
Said Abou-Hallawa
Comment 6 2019-06-08 18:12:14 PDT
Created attachment 371689 [details] Patch for review
Note You need to log in before you can comment on or make changes to this bug.