Summary: | run-webkit-tests: Remove feature detection support | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, don.olmstead, ews-watchlist, glenn, jbedard, pvollan, ross.kirsling, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Fujii Hironori
2019-05-22 02:37:16 PDT
Created attachment 370391 [details]
Patch
Comment on attachment 370391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370391&action=review > LayoutTests/ChangeLog:10 > + Skip all compositing, animations/3d and transforms/3d temporarily. If this is actually temporary, we should put FIXMEs in expectations, otherwise we'll lose track of why they were skipped. Comment on attachment 370391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370391&action=review >> LayoutTests/ChangeLog:10 >> + Skip all compositing, animations/3d and transforms/3d temporarily. > > If this is actually temporary, we should put FIXMEs in expectations, otherwise we'll lose track of why they were skipped. In WinCairo TestExpectations, I added the Skip in "TEMPORARY SKIPS" section. I think no additional comment is needed. https://github.com/WebKit/webkit/blob/d3d6b28920d2f449f918a3c2da9c48d15bb59002/LayoutTests/platform/wincairo/TestExpectations#L1502 In AppleWin TestExpectations, I'm going to move the Skip to "UNREVIEWED failures" section. https://github.com/WebKit/webkit/blob/d3d6b28920d2f449f918a3c2da9c48d15bb59002/LayoutTests/platform/win/TestExpectations#L2601 Created attachment 370477 [details]
Patch
* Addressed review feedbacks.
Comment on attachment 370477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370477&action=review > Tools/ChangeLog:8 > + Feature detection support has been added to Windows port's DRT and Should be: 'Feature detection support was added to DRT for Windows and...' > Tools/ChangeLog:9 > + old run-webkit-tests in Bug 35610. It has been added for NRWT in Likewise: 'It was added for NRWT in...' > Tools/ChangeLog:10 > + Bug 41842. But, it doesn't work for Windows port's DRT because 'But it doesn't work for DRT for Windows because of...' Created attachment 370544 [details]
Patch for landing
Created attachment 370545 [details]
Patch for landing
webkitpy EWS failure is irrelevant for the patch. BuildBot is also failing. https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/4289 Committed r245733: <https://trac.webkit.org/changeset/245733> |