Bug 197812

Summary:

[ews-app] Status bubble should turn orange when any build step fails

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=198000

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2019-05-10 21:00:45 PDT

[ews-app] Status bubble should turn orange when any build step fails. This would be similar to old EWS behavior. This should make engineers pay more attention to the EWS when one of step in build has failed, but the build hasn't finished (EWS might be retrying to confirm if the issue is pre-existing).

It is especially important to look into EWS when there is some failure. EWS might take additional time between finding the first failure and confirming the failure (since it need to retry the patch, and do clean build etc.). During that time status-bubbles should be orange so that they are more noticeable.

Comment 1 Aakash Jain 2019-05-10 21:04:10 PDT

Created attachment 369636 [details]
Patch

Comment 2 WebKit Commit Bot 2019-05-14 09:18:29 PDT

Comment on attachment 369636 [details]
Patch

Clearing flags on attachment: 369636

Committed r245282: <https://trac.webkit.org/changeset/245282>

Comment 3 WebKit Commit Bot 2019-05-14 09:18:31 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2019-05-14 09:19:51 PDT

<rdar://problem/50769123>