Bug 197760

Summary: Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, darin, jer.noble, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Geoffrey Garen 2019-05-09 16:49:30 PDT
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
Comment 1 Geoffrey Garen 2019-05-09 16:51:32 PDT
Created attachment 369530 [details]
Patch
Comment 2 Sihui Liu 2019-05-10 11:52:32 PDT
*** Bug 197789 has been marked as a duplicate of this bug. ***
Comment 3 Sihui Liu 2019-05-10 11:54:45 PDT
Probably just makeSafeToUseMemoryMapForPath as we already know the reproducible case?
Comment 4 Geoffrey Garen 2019-05-10 12:02:54 PDT
Created attachment 369577 [details]
Patch
Comment 5 Geoffrey Garen 2019-05-10 12:40:26 PDT
There seems to be continuing debate about whether makeSafeToUseMemoryMapForPath in WebKit is a sufficient fix. Let's continue to gather these logs (without crashing) to help inform that discussion.
Comment 6 Geoffrey Garen 2019-05-10 14:32:02 PDT
After discussion with Sihui and Jer, I'm going to land this along with the workaround in bug 197789.
Comment 7 Geoffrey Garen 2019-05-10 14:36:48 PDT
Committed r245197: <https://trac.webkit.org/changeset/245197>
Comment 8 Radar WebKit Bug Importer 2019-05-10 14:37:22 PDT
<rdar://problem/50677550>
Comment 9 Darin Adler 2019-05-11 13:03:20 PDT
(In reply to Geoffrey Garen from comment #7)
> Committed r245197: <https://trac.webkit.org/changeset/245197>

The patch landed (not the one reviewed) has indentation that does not match the brace structure of the if statement. The call to makeSafeToUseMemoryMapForPath is done unconditionally, not based not the result of isSafeToUseMemoryMapForPath.
Comment 10 Geoffrey Garen 2019-05-13 11:43:59 PDT
Reopening to attach new patch.
Comment 11 Geoffrey Garen 2019-05-13 11:43:59 PDT
Created attachment 369757 [details]
Patch
Comment 12 WebKit Commit Bot 2019-05-13 14:52:41 PDT
Comment on attachment 369757 [details]
Patch

Clearing flags on attachment: 369757

Committed r245253: <https://trac.webkit.org/changeset/245253>
Comment 13 WebKit Commit Bot 2019-05-13 14:52:43 PDT
All reviewed patches have been landed.  Closing bug.