Summary: | [ews-build] Do not print worker environment variables in each build step | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dean_johnson, ews-watchlist, lforschler, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=199405 https://bugs.webkit.org/show_bug.cgi?id=202698 |
||||||||
Attachments: |
|
Description
Aakash Jain
2019-04-26 10:45:03 PDT
Created attachment 368335 [details]
Patch
Attachment 368335 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:128: [ApplyPatch.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:687: [ArchiveBuiltProduct.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:729: [DownloadBuiltProduct.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:742: [ExtractBuiltProduct.__init__] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:756: [RunAPITests.__init__] Use of super on an old style class [pylint/E1002] [5]
Total errors found: 5 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
looks good to me, except for the style errors... (not sure if that is avoidable) Comment on attachment 368335 [details]
Patch
Maybe it'd be worth setting logEnviron=False in a new base class that inherited from shell.ShellCommand? Such as:
class MinimalLoggingShellCommand(shell.ShellCommand):
logEnviron = False
If you decide not to wrap shell.ShellCommand, I think the style errors can be avoided by moving the logEnviron=False to member vars of each class you want them used for. It's also a bit more clear since that's how other (static) step configurations are set. > class MinimalLoggingShellCommand(shell.ShellCommand): > logEnviron = False logEnviron can not be a class variable, it has to be passed an instance variable (passed in __init__). We noticed similar behavior with 'timeout' in https://github.com/buildbot/buildbot/issues/3887#issuecomment-356736827 Created attachment 372993 [details]
Patch
Comment on attachment 372993 [details] Patch Clearing flags on attachment: 372993 Committed r246882: <https://trac.webkit.org/changeset/246882> All reviewed patches have been landed. Closing bug. |