Bug 197220

Summary: Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 191208    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2019-04-23 17:28:01 PDT
# STEPS TO REPRODUCE: 1. inspect any page 2. clear the network timeline 3. enable "Preserve Log" 4. reload the page => main frame main resource missing
Attachments
Patch (1.83 KB, patch)
2019-04-23 17:31 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (4.16 KB, patch)
2019-04-23 17:41 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (4.43 KB, patch)
2019-04-23 17:44 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-04-23 17:28:52 PDT
<rdar://problem/49960464>
Devin Rousso
Comment 2 2019-04-23 17:31:21 PDT
Created attachment 368090 [details] Patch
Joseph Pecoraro
Comment 3 2019-04-23 17:34:03 PDT
Comment on attachment 368090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368090&action=review I wonder if we should have some kind of test for this. > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes This says main-frame main-resource changes. It also includes sub-frame main-resource changes as well right?
Joseph Pecoraro
Comment 4 2019-04-23 17:34:15 PDT
Comment on attachment 368090 [details] Patch r=me
Devin Rousso
Comment 5 2019-04-23 17:41:48 PDT
Created attachment 368091 [details] Patch
Devin Rousso
Comment 6 2019-04-23 17:44:56 PDT
Created attachment 368092 [details] Patch
Devin Rousso
Comment 7 2019-04-23 17:46:04 PDT
Comment on attachment 368090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368090&action=review >> Source/WebInspectorUI/ChangeLog:3 >> + Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes > > This says main-frame main-resource changes. It also includes sub-frame main-resource changes as well right? Good point. It should also benefit that as well.
WebKit Commit Bot
Comment 8 2019-04-23 18:28:54 PDT
Comment on attachment 368092 [details] Patch Clearing flags on attachment: 368092 Committed r244577: <https://trac.webkit.org/changeset/244577>
WebKit Commit Bot
Comment 9 2019-04-23 18:28:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.