Bug 196920

Summary: Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 196888    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2019-04-15 11:31:44 PDT
# STEPS TO REPRODUCE: 1. inspect any page with a <canvas> 2. go to the Canvas tab 3. click on one of the <canvas> cards => navigation sidebar does not show (and the button to toggle it is disabled)
Attachments
Patch (2.36 KB, patch)
2019-04-15 11:37 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.38 KB, patch)
2019-04-15 11:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-15 11:31:57 PDT
<rdar://problem/49910618>
Devin Rousso
Comment 2 2019-04-15 11:37:01 PDT
Created attachment 367432 [details] Patch
Devin Rousso
Comment 3 2019-04-15 11:39:53 PDT
Created attachment 367433 [details] Patch
Timothy Hatcher
Comment 4 2019-04-15 12:30:53 PDT
Comment on attachment 367433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367433&action=review > Source/WebInspectorUI/ChangeLog:12 > + Now that we no longer call `addSubview` when adding a sidebar panel, we can't check to see > + if `parentSidebar` has been set, as that is just an alias for `parentView`. Told you it would cause regressions. :) Maybe parentSidebar should change, since the Sidebar still holds it and shows it in the navigation bar.
WebKit Commit Bot
Comment 5 2019-04-15 12:57:04 PDT
Comment on attachment 367433 [details] Patch Clearing flags on attachment: 367433 Committed r244282: <https://trac.webkit.org/changeset/244282>
WebKit Commit Bot
Comment 6 2019-04-15 12:57:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.