Bug 196888

Summary: Web Inspector: sidebar panels shouldn't be added as subviews unless visible
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 200797    
Bug Blocks: 196920    
Attachments:
Description Flags
Patch none

Description Devin Rousso 2019-04-12 18:22:08 PDT
Although most of the top-level sidebar panel subclasses will bail if they're not visible, subviews don't have knowledge of that state and may still layout even when the parent panel is hidden.  The only subview of a sidebar should the currently visible panel.
Comment 1 Radar WebKit Bug Importer 2019-04-12 18:22:28 PDT
<rdar://problem/49870659>
Comment 2 Devin Rousso 2019-04-12 18:31:46 PDT
Created attachment 367367 [details]
Patch
Comment 3 Timothy Hatcher 2019-04-15 10:05:25 PDT
Comment on attachment 367367 [details]
Patch

We should keep an eye on this change, it could introduce regressions.
Comment 4 WebKit Commit Bot 2019-04-15 10:27:33 PDT
Comment on attachment 367367 [details]
Patch

Clearing flags on attachment: 367367

Committed r244268: <https://trac.webkit.org/changeset/244268>
Comment 5 WebKit Commit Bot 2019-04-15 10:27:35 PDT
All reviewed patches have been landed.  Closing bug.