Bug 196780

Summary:

[ews-build] PrintConfiguration should display Xcode version instead of SDKVersion

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, lforschler, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=195945
https://bugs.webkit.org/show_bug.cgi?id=196752

Attachments:

Description	Flags
Patch	none

Aakash Jain

Reported 2019-04-10 13:56:03 PDT

PrintConfiguration should display Xcode version (e.g.: Xcode: 9.4.1) instead of SDKVersion(e.g.: 10.13).

Attachments
Patch (2.17 KB, patch) 2019-04-10 13:57 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-10 13:57:09 PDT

Created attachment 367159 [details] Patch

EWS Watchlist

Comment 2 2019-04-10 13:58:50 PDT Comment hidden (obsolete)

Attachment 367159 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 3 2019-04-10 15:08:19 PDT

Sample run: https://ews-build.webkit-uat.org/#/builders/33/builds/4059

WebKit Commit Bot

Comment 4 2019-04-10 16:04:21 PDT

Comment on attachment 367159 [details] Patch Clearing flags on attachment: 367159 Committed r244164: <https://trac.webkit.org/changeset/244164>

WebKit Commit Bot

Comment 5 2019-04-10 16:04:22 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2019-04-10 16:05:27 PDT

<rdar://problem/49794460>

Note You need to log in before you can comment on or make changes to this bug.