| Summary: | [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dewei_zhu, ews-watchlist, lforschler, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=195945 https://bugs.webkit.org/show_bug.cgi?id=196752 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2019-04-10 13:56:03 PDT
Created attachment 367159 [details]
Patch
Attachment 367159 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 367159 [details] Patch Clearing flags on attachment: 367159 Committed r244164: <https://trac.webkit.org/changeset/244164> All reviewed patches have been landed. Closing bug. |