Bug 196752 – [ews-build] Add unit tests for PrintConfiguration

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We should add unit tests for PrintConfiguration build step in ews-build.

[Aakash Jain]

Created attachment 367085 [details]
Patch

[EWS Watchlist]

Attachment 367085 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1260:  [TestPrintConfiguration.test_success] Undefined variable 'PrintConfiguration'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294:  [TestPrintConfiguration.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294:  [TestPrintConfiguration.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1298:  [TestPrintConfiguration.test_failure] Undefined variable 'PrintConfiguration'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1330:  [TestPrintConfiguration.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1330:  [TestPrintConfiguration.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 367085 [details]
Patch

Clearing flags on attachment: 367085

Committed r244102: <https://trac.webkit.org/changeset/244102>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49758837>