Web Inspector: Timelines: can't reliably stop/start a recording

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Sometimes you can't reliably stop/start a timeline recording by clicking the button or hitting the spacebar.

# STEPS TO REPRODUCE:
1. inspect <https://wkwebviewtest.surge.sh>
2. go to the Timelines tab
3. reload the page, which will trigger a timeline recording (make sure "Stop recording once page loads" is NOT checked)
4. when the recording stops after 2s, immediately click the record button to resume the recording
 => recording doesn't always resume.

[Devin Rousso]

<rdar://problem/47606798>

[Devin Rousso]

Created attachment 367156 [details]
Patch

Patch to see how bots like the new state system.

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[WebKit Commit Bot]

Comment on attachment 367156 [details]
Patch

Clearing flags on attachment: 367156

Committed r244158: <https://trac.webkit.org/changeset/244158>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/244158/webkit

has caused 8 test failures: 
inspector/timeline/line-column.html
inspector/timeline/timeline-event-CancelAnimationFrame.html
inspector/timeline/timeline-event-FireAnimationFrame.html
inspector/timeline/timeline-event-RequestAnimationFrame.html
inspector/timeline/timeline-event-TimerFire.html
inspector/timeline/timeline-event-TimerInstall.html
inspector/timeline/timeline-event-TimerRemove.html
inspector/timeline/timeline-recording.html

These tests are effecting all of Mac. Can this be resolved quickly? 

Diff of inspector/timeline/line-column.html:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244167%20(10623)/inspector/timeline/line-column-diff.txt

History of inspector/timeline/line-column.html:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Fline-column.html

[Truitt Savell]

Reverted r244158 for reason:

Casued 8 inspector/timeline/ test failures.

Committed r244191: <https://trac.webkit.org/changeset/244191>

[Devin Rousso]

Created attachment 367230 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367230 [details]
Patch

Rejecting attachment 367230 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 367230, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11844142

[Devin Rousso]

Created attachment 367235 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367235 [details]
Patch

Rejecting attachment 367235 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 367235, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11844224

[Devin Rousso]

Created attachment 367236 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367236 [details]
Patch

Clearing flags on attachment: 367236

Committed r244195: <https://trac.webkit.org/changeset/244195>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.