| Summary: | [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, graouts, mitz, simon.fraser, thorton, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209669 | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2019-04-09 13:10:45 PDT
Created attachment 367072 [details]
Patch
Committed r244098: <https://trac.webkit.org/changeset/244098> It looks like the changes in https://trac.webkit.org/changeset/244098/webkit are most likely responsible for the test fast/dynamic/paused-event-dispatch.html becoming a timeout. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fdynamic%2Fpaused-event-dispatch.html build: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK1%20(Tests)/builds/2992 (In reply to Truitt Savell from comment #4) > It looks like the changes in https://trac.webkit.org/changeset/244098/webkit > > are most likely responsible for the test > fast/dynamic/paused-event-dispatch.html becoming a timeout. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=fast%2Fdynamic%2Fpaused-event-dispatch.html > > build: > https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK1%20(Tests)/ > builds/2992 That's quite surprising because this testcase does not exercise auto-sizing at all. We were able to reproduce this failure using command: run-webkit-tests fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html fast/dynamic/paused-event-dispatch.html -1 --no-retry running the test fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html, added in 244098, in front of the timing out test causes the timeout. (In reply to Truitt Savell from comment #6) > We were able to reproduce this failure using command: > > run-webkit-tests > fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html > fast/dynamic/paused-event-dispatch.html -1 --no-retry > > running the test > fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html, added in > 244098, in front of the timing out test causes the timeout. Ok. Thanks! I'll look into it. This patch actually revealed a bug in the test framework. We don't reset the auto-sizing mode for subsequent runs. *** Bug 196789 has been marked as a duplicate of this bug. *** Tracking the test failure and underlying framework bug in https://bugs.webkit.org/show_bug.cgi?id=196789 |