Bug 196673

Summary:

Broken API Test TestWebKitAPI.SafeBrowsing.WKWebViewGoBackIFrame

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

aakash_jain, achristensen, ap, lforschler, webkit-bot-watchers-bugzilla

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196665
https://bugs.webkit.org/show_bug.cgi?id=196688

Attachments:

Description	Flags
Patch	none

Aakash Jain

Reported 2019-04-06 03:37:01 PDT

TestWebKitAPI.SafeBrowsing.WKWebViewGoBackIFrame is consistently timing out on iOS. It was recently added in https://bugs.webkit.org/show_bug.cgi?id=196665 e.g.: https://ews-build.webkit.org/#/builders/9/builds/197 https://ews-build.webkit.org/#/builders/9/builds/198 https://ews-build.webkit.org/#/builders/9/builds/199 https://ews-build.webkit.org/#/builders/9/builds/200 https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3494/steps/run-api-tests/logs/stdio

Attachments
Patch (1.40 KB, patch) 2019-04-06 03:40 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-06 03:40:19 PDT

Created attachment 366883 [details] Patch

Alexey Proskuryakov

Comment 2 2019-04-07 18:39:07 PDT

We should just roll back the patch. It is not OK to land fixes without tests, and a broken test is equivalent to no test.

Alexey Proskuryakov

Comment 3 2019-04-07 18:39:30 PDT

No review needed for rollback.

Aakash Jain

Comment 4 2019-04-07 19:59:25 PDT

(In reply to Alexey Proskuryakov from comment #2) > We should just roll back the patch. It is not OK to land fixes without tests, and a broken test is equivalent to no test. Rolled out in https://bugs.webkit.org/show_bug.cgi?id=196688

Aakash Jain

Comment 5 2019-04-07 20:00:23 PDT

*** This bug has been marked as a duplicate of bug 196688 ***

Note You need to log in before you can comment on or make changes to this bug.