| Summary: | [ews-build] Make PrintConfiguration platform aware | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, aperez, ap, clopez, commit-queue, ews-watchlist, lforschler, mcatanzaro, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=199234 | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2019-04-05 14:42:29 PDT
Created attachment 366844 [details]
Patch
Attachment 366844 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:912: [PrintConfiguration.run] Use of super on an old style class [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:913: [PrintConfiguration.run] Instance of 'PrintConfiguration' has no 'getProperty' member [pylint/E1101] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 373314 [details]
Patch
Comment on attachment 373314 [details] Patch Clearing flags on attachment: 373314 Committed r247049: <https://trac.webkit.org/changeset/247049> All reviewed patches have been landed. Closing bug. |