Summary: | Update touch-action region on property changes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Scrolling | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=196536 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 194813 | ||||||||
Attachments: |
|
Description
Antti Koivisto
2019-04-04 09:01:19 PDT
Created attachment 366928 [details]
patch
Created attachment 366934 [details]
patch
Comment on attachment 366934 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=366934&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2489 > + m_owningLayer.invalidateEventRegion(); It's a shame to trigger expensive event region building for non-layout changes like color changes. Can we use a StyleDiff somewhere instead? Imagine an animation of background-color triggering region rebuilds every frame :( > It's a shame to trigger expensive event region building for non-layout
> changes like color changes. Can we use a StyleDiff somewhere instead?
> Imagine an animation of background-color triggering region rebuilds every
> frame :(
We could certainly implement finer grained invalidation. Not sure yet if it is worth additional complexity, in most cases (at least when touch-action is not involved) region building should be very cheap due to ability to bail out early in the common case. We'll see if it actually shows up in profiles.
Comment on attachment 366934 [details] patch Clearing flags on attachment: 366934 Committed r244037: <https://trac.webkit.org/changeset/244037> All reviewed patches have been landed. Closing bug. |