Bug 196608

Summary: Update touch-action region on property changes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: ScrollingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196536
Bug Depends on:    
Bug Blocks: 194813    
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2019-04-04 09:01:19 PDT
Verify that we react do changes to touch-action correctly.
Attachments
patch (9.36 KB, patch)
2019-04-08 05:53 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (9.61 KB, patch)
2019-04-08 07:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-04-08 05:53:34 PDT
Created attachment 366928 [details] patch
Antti Koivisto
Comment 2 2019-04-08 07:23:38 PDT
Created attachment 366934 [details] patch
Radar WebKit Bug Importer
Comment 3 2019-04-08 12:45:15 PDT
<rdar://problem/49706912>
Simon Fraser (smfr)
Comment 4 2019-04-08 13:01:50 PDT
Comment on attachment 366934 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=366934&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2489 > + m_owningLayer.invalidateEventRegion(); It's a shame to trigger expensive event region building for non-layout changes like color changes. Can we use a StyleDiff somewhere instead? Imagine an animation of background-color triggering region rebuilds every frame :(
Antti Koivisto
Comment 5 2019-04-08 13:07:50 PDT
> It's a shame to trigger expensive event region building for non-layout > changes like color changes. Can we use a StyleDiff somewhere instead? > Imagine an animation of background-color triggering region rebuilds every > frame :( We could certainly implement finer grained invalidation. Not sure yet if it is worth additional complexity, in most cases (at least when touch-action is not involved) region building should be very cheap due to ability to bail out early in the common case. We'll see if it actually shows up in profiles.
WebKit Commit Bot
Comment 6 2019-04-08 13:33:00 PDT
Comment on attachment 366934 [details] patch Clearing flags on attachment: 366934 Committed r244037: <https://trac.webkit.org/changeset/244037>
WebKit Commit Bot
Comment 7 2019-04-08 13:33:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.