Summary: | [ATK] Use a smart pointer for AccessibilityObject wrapper and remove GTK specific code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, jdiggs, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | Gtk, InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-04-04 01:20:31 PDT
Created attachment 366703 [details]
Patch
Comment on attachment 366703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366703&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324 > return 0; return nullptr; > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350 > + return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr; Two more opportunities to return nullptr up above, as well. (In reply to Michael Catanzaro from comment #3) > Comment on attachment 366703 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366703&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324 > > return 0; > > return nullptr; > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350 > > + return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr; > > Two more opportunities to return nullptr up above, as well. WebKitAccessibleWrapperAtk is cleaned up in bug #196601 Committed r243928: <https://trac.webkit.org/changeset/243928> |