Bug 196593

Summary: [ATK] Use a smart pointer for AccessibilityObject wrapper and remove GTK specific code
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, jdiggs, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2019-04-04 01:20:31 PDT
We have specific code for GTK to get/set the wrapper only because we don't use smart pointers.
Attachments
Patch (33.64 KB, patch)
2019-04-04 01:24 PDT, Carlos Garcia Campos
mcatanzaro: review+
Radar WebKit Bug Importer
Comment 1 2019-04-04 01:20:42 PDT
Carlos Garcia Campos
Comment 2 2019-04-04 01:24:33 PDT
Michael Catanzaro
Comment 3 2019-04-04 08:41:42 PDT
Comment on attachment 366703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366703&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324 > return 0; return nullptr; > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350 > + return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr; Two more opportunities to return nullptr up above, as well.
Carlos Garcia Campos
Comment 4 2019-04-05 00:34:56 PDT
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 366703 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366703&action=review > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324 > > return 0; > > return nullptr; > > > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350 > > + return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr; > > Two more opportunities to return nullptr up above, as well. WebKitAccessibleWrapperAtk is cleaned up in bug #196601
Carlos Garcia Campos
Comment 5 2019-04-05 00:35:30 PDT
Note You need to log in before you can comment on or make changes to this bug.