Bug 196535

Summary:

[ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, jdiggs, mario, mcatanzaro

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

196534

Bug Blocks:

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Carlos Garcia Campos 2019-04-03 05:54:25 PDT

This way the properties are not cached. Right now, if number of children is queried before the socket is embedded, 0 is returned and cached, so ATs don't see the child even after the socket has been embedded.

Comment 1 Carlos Garcia Campos 2019-04-03 05:56:50 PDT

Created attachment 366593 [details]
Patch

Comment 2 Carlos Garcia Campos 2019-04-03 22:51:44 PDT

Committed r243862: <https://trac.webkit.org/changeset/243862>

Comment 3 Mario Sanchez Prada 2019-04-05 01:39:11 PDT

Another late drive-by review: lgtm